Re: [PATCH version 2] [SQUASHME] "FC Pass Thru support" fixed forblock/for-2.6.31 tree

[Boaz Harrosh]

On 05/20/2009 07:59 PM, Boaz Harrosh wrote:
> On 05/20/2009 07:43 PM, James Bottomley wrote:
>> If you actually just ask scsi-post-merge-2.6 where this line is, it will
>> tell you:
>>
>> static void blk_finish_request(struct request *req, int error)
>> {
>>         BUG_ON(blk_queued_rq(req));
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>
>>         if (blk_rq_tagged(req))
>>                 blk_queue_end_tag(req->q, req);
>>
>> James
>>
>>
> 
> This is a new BUG_ON from:
>     block: implement and enforce request peek/start/fetch
> 
> It looks like there is one more sight of the old usage that
> was not converted.
> 
> Tejun?
>  

The patch has a comment about that:
    * disallowing completion of queued (not started) requests

Do you have a stack trace?

Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/