Re: [PATCH] ieee1394: eth1394: use "firewire%d" instead of "eth%d"as interface name

From: Stefan Richter
Date: Thu May 21 2009 - 16:14:37 EST


David Miller wrote:
From: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx>
Date: Thu, 21 May 2009 15:29:10 +0200 (CEST)
Change the initial name of IP-over-1394 networking interfaces from
"eth[0-9]+" to "firewire[0-9]+".
...
I think the basis for this patch is completely bogus.

Device names are just that, names. If you want to know "what it is"
or "where it is" you use tools to determine that information.

If you make ethtool's get info command return something useful,
then the user can see that it's a firewire interface and act
accordingly, as can sophisticated confiruation applications.

I am completely against this patch.

Ethtool shows:
driver: eth1394
version:
firmware-version:
bus-info: ieee1394
And the sysfs representations of the netdevices have an fw-host* device in the parent device chain.

I agree that userland should read less into names as they are handed out by the kernel. I am also aware that it depends on the use case what naming scheme can be considered useful, hence userspace needs to give his own names anyway, regardless of how the kernel named it.

But I mildly disagree with the notion that the kernel can't start off with more qualification of the names than merely ensuring their uniqueness. Or the other way around: Even an entirely meaningless prefix would be better than "eth..", or no prefix if that's possible, because eth suspiciously sounds like Ethernet with which the misnamed RFC 2734 driver eth1394 has very little to do.

However, how mild my disagreement is should be apparent from the fact that I didn't bother to suggest changing it before now, in 2009. :-)
--
Stefan Richter
-=====-=-=== -=-= -==-=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/