[PATCH 3/9] amd-iommu: drop pointless iommu-loop in msi setup code

From: Joerg Roedel
Date: Fri May 22 2009 - 08:17:00 EST


Impact: cleanup

It is not necessary to loop again over all IOMMUs in this code. So drop
the loop.

Signed-off-by: Joerg Roedel <joerg.roedel@xxxxxxx>
---
arch/x86/kernel/amd_iommu_init.c | 8 +-------
1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c
index 74f4f1f..cc99f60 100644
--- a/arch/x86/kernel/amd_iommu_init.c
+++ b/arch/x86/kernel/amd_iommu_init.c
@@ -826,13 +826,6 @@ out_free:
static int __init iommu_setup_msi(struct amd_iommu *iommu)
{
int r;
- struct amd_iommu *curr;
-
- for_each_iommu(curr) {
- if (curr->dev == iommu->dev)
- curr->int_enabled = true;
- }
-

if (pci_enable_msi(iommu->dev))
return 1;
@@ -847,6 +840,7 @@ static int __init iommu_setup_msi(struct amd_iommu *iommu)
return 1;
}

+ iommu->int_enabled = true;
iommu_feature_enable(iommu, CONTROL_EVT_INT_EN);

return 0;
--
1.6.3.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/