Re: [PATCH 3/3] drivers/ide/ide-core: Unsplit constant strings forpr_<level> and dev_<level>
From: Joe Perches
Date: Sun May 24 2009 - 12:48:03 EST
On Sun, 2009-05-24 at 16:12 +0400, Sergei Shtylyov wrote:
> > - dev_err(&drive->gendev, "%s: packet size (0x%02x) is not 12 "
> > - "bytes\n", s, packet_size);
> > + dev_err(&drive->gendev,
> > + "%s: packet size (0x%02x) is not 12 bytes\n",
> When the message is broken by the format specifier, turning it into
> one liner can hardly help seraching...
grep "is not 12 bytes"
> Oh noes, the indentation...
> > + "(IO,CoD != (0,1) while issuing a packet command, retrying\n");
You seem to sigh a lot. ;)
> > + "(IO,CoD != (0,1) while issuing a packet command, ignoring\n");
> > + "Strange, packet command initiated yet DRQ isn't asserted\n");
> > + "(IO,CoD) != (0,1) while issuing a packet command\n");
> > + "unexpected interrupt, status=0x%02x, count=%ld\n",
> Hardly won anything...
> > + "%s side 80-wire cable detection failed, limiting max speed to UDMA33\n",
> Will you really use the full message to serch here?
> > + "probing with STATUS(0x%02x) instead of ALTSTATUS(0x%02x)\n",
> Same comment about the line broken by the format specifiers. This
> wins absolutely nothing.
> > + "no response (status = 0x%02x), resetting drive\n",
> And again...
> > + "%s Multimode Write multcount is not set\n",
> > + "%s Multimode Read failure multcount is not set\n",
> > + "%s %s: device not capable of full native PCI mode\n",
> > + "%s %s: rewrite of PROGIF failed, wanted 0x%04x, got 0x%04x\n",
> > + "%s %s: I/O baseregs (BIOS) are reported as MEM for port %d!\n",
> > + "%s %s: not 100%% native mode: will probe irqs later\n",
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/