Re: [RFC PATCH 5/X] ptrace: mv task_struct->ptraceptrace_task->pt_flags, kill ptrace_link()

From: Ingo Molnar
Date: Sun May 24 2009 - 23:33:33 EST

* Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> struct ptrace_task {
> + unsigned long pt_flags;
> };

> - return task->ptrace;
> + return unlikely(task->ptrace_task) ?
> + task->ptrace_task->pt_flags : 0;

Please no pt_ prefixes. It is abundantly clear from the
'->ptrace_ctx' portion already that it's about ptrace - the rest
should be a straightforward minimalistic naming - i.e.

Also, is the conditional necessary? We should not be calling ptrace
methods on tasks with no ptrace context.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at