Re: [PATCH,RFC] gianfar: fix BUG under load after introduction ofskb recycling
From: David Miller
Date: Mon May 25 2009 - 03:43:56 EST
From: Michael Guntsche <mike@xxxxxxxxxxxx>
Date: Sun, 24 May 2009 17:32:05 +0200
> On May 23, 2009, at 13:51, Lennert Buytenhek wrote:
>> Since commit 0fd56bb5be6455d0d42241e65aed057244665e5e ("gianfar:
>> Add support for skb recycling"), gianfar puts skbuffs that are in
>> the rx ring back onto the recycle list as-is in case there was a
>> receive error, but this breaks the following invariant: that all
>> skbuffs on the recycle list have skb->data = skb->head + NET_SKB_PAD.
>> Michael, can you re-test with this version of the patch?
>> Andy, can you see if this is OK with you?
> Hi, I have been running tests with this patch for the last 6 hours and
> had no panics so far.
> So it fixes the issues I am seeing as well.
Since it's now tested, I am applying this to net-2.6 to expedite it's
inclusion into 2.6.30
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/