Re: [PATCH resend4 2/3] itimers: fix periodic tics precision

From: Thomas Gleixner
Date: Mon May 25 2009 - 08:33:26 EST


On Mon, 25 May 2009, Stanislaw Gruszka wrote:
> @@ -904,6 +905,7 @@ void __init time_init(void)
> tb_ticks_per_usec = ppc_tb_freq / 1000000;
> tb_to_us = mulhwu_scale_factor(ppc_tb_freq, 1000000);
> calc_cputime_factors();
> + cputime_one = jiffies_to_cputime(1);

1) The variable name is misleading.

2) The patch breaks all powerpc platforms which have
CONFIG_VIRT_CPU_ACCOUNTING=n and ia64 with
CONFIG_VIRT_CPU_ACCOUNTING=y

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/