Re: [PATCH 2/3] ide: preserve HPA by default

[Frans Pop]

Bartlomiej Zolnierkiewicz wrote:
> --- a/drivers/ide/Kconfig
> +++ b/drivers/ide/Kconfig
> @@ -91,6 +91,28 @@ config BLK_DEV_IDE_SATA
[...]
> +config IDE_PRESERVE_HPA
> +       bool "Preserve Host Protected Area (please read help)"
> +       default y
> +       help
> +         From the majority of modern users perspectives ignoring the HPA
> +         breaks vendor RAID formats, GPT partitions or risks corrupting
> +         firmware.

First sentence would IMO read better as:
"From the perspective of most users of recent systems, ignoring the
 HPA can break ..."

Maybe add "risks overwriting vendor system recovery tools"?

> +         Unfortunately the original (kernel versions < 2.6.30) behavior
> +         (ignoring HPA, using full disk capacity) was introduced at the
> +         time when the main HPA use was with the jumper (or software)
> +         to make the drive look small enough for the BIOS to allow boot
> +         with big drives.

"... the main use of HPA was to make the drive look small enough for the
 BIOS to allow the system to boot with large capacity drives."

I've dropped the "with the jumper (or software)" as it's confusing and
IMHO does not really add anything for the user (but see suggestion below).

> +         To allow the maximum compatibility with the existing setups
> +         (using HPA and partitioned with HPA disabled) the default HPA
> +         behavior can be also later adjusted using "ignore_hpa" module
> +         parameter (i.e. "ide_core.ignore_hpa=1").

"... can also be adjusted later using the "ignore_hpa" ..."

Maybe add a para here that explains what "Preserve Host Protected Area"
actually does, something like:
"If you say Y, the driver will respect the Host Protected Area if one is
 defined in the BIOS or (for older drives) through a jumper setting on
 the drive."

> +         Say Y unless you have such setup and for some reason cannot
> +         use "ignore_hpa" module parameter.

"... use the "ignore_hpa" module parameter."

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/