Re: [PATCH] drivers/char/rtc: disable legacy RTC driver on Blackfin systems
From: Paul Mundt
Date: Tue May 26 2009 - 07:23:08 EST
On Tue, May 26, 2009 at 06:25:02AM -0400, Christoph Hellwig wrote:
> On Tue, May 26, 2009 at 06:10:33AM -0400, Mike Frysinger wrote:
> > tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)"
> > depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV \
> > - && !ARM && !SUPERH && !S390 && !AVR32
> > + && !ARM && !SUPERH && !S390 && !AVR32 && !BLACKFIN
> Maybe it's better to have a positive dependency for those that actually
> support it these days? Based on the above list that would be:
> depends on ALPHA || CRIS || H8300 || M32R || MICROBLAZE ||
> MIPS || MN10300 || SH || X86 || XTENSA
> and I would not be surprised if some of the above don't actually support
> it either..
SH shouldn't be included it, we've never supported it. Out of the ones
that do support this interface, I would guess that they should require
little to no modification to work with drivers/rtc/rtc-cmos.c.
Out of the ones that don't actually support this interface but never
bothered updating the Kconfig bits.. none of h8300/microblaze/xtensa
define any of the CMOS_READ/WRITE() accessors, so this has no chance at
all of working there.
Now to narrow that list down a bit more, both m32r and cris primarily use
this interface for their ds1302 RTC, which I added a stub driver for in
drivers/rtc/rtc-ds1302.c some time ago. With a bit of cleanup on the
driver side and a bit of a push from the architecture side, they should
also be able to just use the drivers/rtc version directly. I've offered
to help with the conversion for these platforms before, but neither
maintainer seemed terribly responsive.
Which basically leaves just alpha, mips, mn10300, and x86. I would be
surprised if these don't work with rtc-cmos already today.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/