[PATCH -tip][SCSI] scsi: scsi_transport_iscsi.c initialize thevariable before it get used

From: Jaswinder Singh Rajput
Date: Tue May 26 2009 - 11:20:01 EST


I am watching this problem from long time in -tip.

Subject: [PATCH] scsi: scsi_transport_iscsi.c initialize the variable before it get used

In some cases, err will be used uninitialized.

Also fixed compilation warning :

CC drivers/scsi/scsi_transport_iscsi.o
drivers/scsi/scsi_transport_iscsi.c: In function âiscsi_add_sessionâ:
drivers/scsi/scsi_transport_iscsi.c:678: warning: âerrâ may be used uninitialized in this function

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>
---
drivers/scsi/scsi_transport_iscsi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index 0947954..e78cde2 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -675,7 +675,7 @@ int iscsi_add_session(struct iscsi_cls_session *session, unsigned int target_id)
struct iscsi_cls_host *ihost;
unsigned long flags;
unsigned int id = target_id;
- int err;
+ int err = 0;

ihost = shost->shost_data;
session->sid = atomic_add_return(1, &iscsi_session_nr);
--
1.6.0.6



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/