Re: Bug in SCSI async probing

[James Bottomley]

On Tue, 2009-05-26 at 11:22 -0400, Alan Stern wrote:
> James & Arjan:
> 
> Am I missing something here?  It looks like
> 
> 	fastboot: make scsi probes asynchronous
> 
> has introduced a bug in the sd probing code.  AFAICT, there is now
> nothing to prevent do_scan_async() from returning before
> sd_probe_async() has run.

True, but this isn't really a problem.

> Doesn't this mean that there's nothing to prevent sd_remove() from 
> being called and trying to unregister the disk _before_ 
> sd_probe_async() has managed to register it?

Yes, we've been discussing this ... most of the removal functions now
need async_synchronize calls to mitigate this type of race.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/