Re: [PATCH] tracing: create events only when configed
From: Steven Rostedt
Date: Tue May 26 2009 - 12:38:56 EST
On Fri, 22 May 2009, Lai Jiangshan wrote:
> There some unneeded events in debugfs/tracing/ftrace/ when the
> corresponding CONFIG_XXXX=n.
> And when CONFIG_ENABLE_EVENT_TRACING=n, various events
> are still created.
> Now when CONFIG_ENABLE_EVENT_TRACING=n, various events are
> not created, trace_export.c is compiled only for creating
> [Impact:] cleanup
I have an issue with this patch. I purposely kept the
debugfs/tracing/ftrace events there since you may have a binary buffer
that you want to read that has those events but you are not running a
kernel that enabled them. But I guess the counter arguement for that is
then those events may not be the same offset as the kernel that ran it.
OK, maybe it would be fine to disable the events if the kernel does not
use them. We should also put the same #ifdef's around the structs to make
sure no other trace uses them.
Still seems a bit messy with all those ifdefs :-/
The second change with the CONFIG_ENABLE_EVENT_TRACER is something that we
are having issue with the make scripts. We want EVENT_TRACE enabled
anytime TRACING is enabled. We do _not_ want to disable it.
The config option is there to enable event_tracer when on other tracing is
enabled. But we can't get rid of the option when tracing is enabled,
because we run into circular dependecies. Here's what we want:
prompt "select event tracer"
depends on !TRACING
Which we then get an error creating the kbuild system due to dependency
The event tracer prompt should not be there when tracing is selected,
since we already have events, but I have yet to figure out how to get rid
Thus, I'll be OK with the first part of your patch, but I'm against the
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/