Re: [PATCH][mmtom] clean up once printk routine
From: Andrew Morton
Date: Tue May 26 2009 - 16:42:44 EST
On Tue, 26 May 2009 15:59:43 +0900
Minchan Kim <minchan.kim@xxxxxxxxx> wrote:
> On Tue, 26 May 2009 15:52:32 +0900 (JST)
> KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote:
> > > == CUT HERE ==
> > >
> > > There are some places to be able to use printk_once instead of hard coding.
> > >
> > > It will help code readability and maintenance.
> > > This patch doesn't change function's behavior.
> > >
> > > Signed-off-by: Minchan Kim <minchan.kim@xxxxxxxxx>
> > > CC: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>
> > > CC: David S. Miller <davem@xxxxxxxxxxxxx>
> > > CC: Ingo Molnar <mingo@xxxxxxx>
> > > ---
> > > arch/x86/kernel/cpu/common.c | 8 ++------
> > > drivers/net/3c515.c | 7 ++-----
> > > drivers/pcmcia/pcmcia_ioctl.c | 9 +++------
> > > 3 files changed, 7 insertions(+), 17 deletions(-)
> > Please separete to three patches ;)
> After I listen about things I missed, I will repost it at all once with each patch.
Yes, that would be better. But for a trivial little patch like this I
expect we can just merge it and move on. But please do split up these
multi-subsystem patches in future.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/