Re: [PATCH v2 1/2] tracing/events: make __string() more general

From: Steven Rostedt
Date: Tue May 26 2009 - 16:56:55 EST

On Tue, 26 May 2009, Li Zefan wrote:

> This changes __string(..., src) to __string(..., len), thus makes it more
> general, and then block TRACE_EVENT() can use it.
> Also introduce __fetch_str(), which is used in TP_assign() and returns
> the address of the string, while __get_str() is used in TP_print().
> [ Impact: TRACE_EVENT api change ]

What's the reason for the change?

Is it to handle NULL pointers? If so, lets change the ftrace.h to handle
it instead.

This is why I like the Impact line really be a "rational" line.
"TRACE_EVENT api change" is meaningless to me.

-- Steve
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at