Re: [PATCH 2/3] add inactive ratio calculation function of eachzone V2

[Andrew Morton]

On Thu, 21 May 2009 09:23:21 +0900 Minchan Kim <minchan.kim@xxxxxxxxx> wrote:

> Changelog since V1 
>  o Change function name from calculate_zone_inactive_ratio to calculate_inactive_ratio
>    - by Mel Gorman advise
>  o Modify tab indent - by Mel Gorman advise

The first two patches still had various trivial whitespace bustages. 
You don't need Mel to find these things when we have the very nice
scripts/checkpatch.pl.  Please incorporate that script into your patch
preparation tools

> This patch devide setup_per_zone_inactive_ratio with
> per-zone inactive ratio calculaton.

The above sentence appears to be the changelog for this patch but it
doesn't make a lot of sense.

afaict the changelog should be:

"factor the per-zone arithemetic inside
setup_per_zone_inactive_ratio()'s loop into a a separate function,
calculate_zone_inactive_ratio().  This function will be used in a later
patch".

yes?


> This patch is just for helping my next patch.
> (reset wmark_min and inactive ratio of zone when hotplug happens)
> 
> Signed-off-by: Minchan Kim <minchan.kim@xxxxxxxxx>
> Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
> CC: Rik van Riel <riel@xxxxxxxxxx>
> CC: Johannes Weiner <hannes@xxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/