Re: [PATCH v2 1/2] tracing/events: make __string() more general
From: Christoph Hellwig
Date: Wed May 27 2009 - 03:24:39 EST
On Wed, May 27, 2009 at 09:24:21AM +0800, Li Zefan wrote:
> Seems Christoph also runs into this problem while doing his XFS tracing.
> (and NULL str ptr that I'm not suffering)
Yeah. What I'm doing is tracing the XFS directory code. For some
reason unknown to mankind people decided not to store the 0 termination
on disk because we have the string length in the dirent anyway. So
beeing able to specify the length is important to me, aswell as dealing
with NULL strings because there are some directory operations that
are internal and don't deal with any entry and thus don't have a name
associated with them.
> > This is why I like the Impact line really be a "rational" line.
> > "TRACE_EVENT api change" is meaningless to me.
> So what should this impact be. :(
Another reason for just dropping the impact Lines. I had hope people
would just stop adding it after the last
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/