Re: [RFC][PATCH] [SCSI]: scsi_transport_iscsi.c return -EOVERFLOWfor Too many iscsi targets

From: Mike Christie
Date: Wed May 27 2009 - 10:28:38 EST

Jaswinder Singh Rajput wrote:
setting err as -EOVERFLOW for Too many iscsi targets.

Also fixes compiler warning for gcc < 4.3.3 :

CC drivers/scsi/scsi_transport_iscsi.o
drivers/scsi/scsi_transport_iscsi.c: In function âiscsi_add_sessionâ:
drivers/scsi/scsi_transport_iscsi.c:678: warning: âerrâ may be used uninitialized in this function

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>
drivers/scsi/scsi_transport_iscsi.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index 0947954..fdcda7f 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -693,6 +693,7 @@ int iscsi_add_session(struct iscsi_cls_session *session, unsigned int target_id)
"Too many iscsi targets. Max "
"number of targets is %d.\n",
+ err = -EOVERFLOW;
goto release_host;

Fine by me. Send it through whatever tree you guys want.

Acked-by: Mike Christie <michaelc@xxxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at