Re: [PATCH 17/17] xen: disable MSI

From: Linus Torvalds
Date: Wed May 27 2009 - 11:43:43 EST

On Wed, 27 May 2009, Jeremy Fitzhardinge wrote:
> [ Impact: prevent MSI subsystem from crashing ]


I looked at several of these impact lines, and they were _all_ totally

Please, guys. Stop with the F*CKING impact lines already. Add them if they
are obvious, but don't make them this idiotic "do an impact line whether
or not it makes sense".

I hate them. They are stupid. 90% of all the impact lines I see are either
(a) misleading or (b) totally inane and pointless.

In this case, we would have been a LOT BETTER OFF with having just a
better header line that said "xen: disable MSI to avoid crash" or
something like that. But no. THAT F*CKING IMPACT LINE apparently meant
that Jeremy just turned off his brain, and made _both_ the header line and
the Impact: line be non-descriptive.

Really. Stop it. Ingo, start saying "no" to people, at least for impact
lines that do not make sense. It adds _nothing_, and it actually detracts
from real content, because just the inanity of them delutes the whole
meaning of it.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at