Re: [PATCH -v3] flat: fix data sections alignment

[Mike Frysinger]

On Thu, Apr 9, 2009 at 10:25, Johannes Weiner wrote:
> On Thu, Apr 02, 2009 at 01:53:43PM -0700, Andrew Morton wrote:
>> On Tue, 10 Mar 2009 16:33:50 +0900
>> Paul Mundt <lethal@xxxxxxxxxxxx> wrote:
>>
>> > On Thu, Mar 05, 2009 at 06:00:59PM +0100, Oskar Schirmer wrote:
>> > > The flat loader uses an architecture's flat_stack_align() to align the
>> > > stack but assumes word-alignment is enough for the data sections.
>> > >
>> > > However, on the Xtensa S6000 we have registers up to 128bit width
>> > > which can be used from userspace and therefor need userspace stack and
>> > > data-section alignment of at least this size.
>> > >
>> > > This patch drops flat_stack_align() and uses the same alignment that
>> > > is required for slab caches, ARCH_SLAB_MINALIGN, or wordsize if it's
>> > > not defined by the architecture.
>> > >
>> > > It also fixes m32r which was obviously kaput, aligning an
>> > > uninitialized stack entry instead of the stack pointer.
>> > >
>> > > Signed-off-by: Oskar Schirmer <os@xxxxxxxxx>
>> > > Signed-off-by: Johannes Weiner <jw@xxxxxxxxx>
>> > > Cc: David Howells <dhowells@xxxxxxxxxx>
>> > > Cc: Russell King <rmk@xxxxxxxxxxxxxxxx>
>> > > Cc: Bryan Wu <cooloney@xxxxxxxxxx>
>> > > Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>> > > Cc: Paul Mundt <lethal@xxxxxxxxxxxx>
>> > > Cc: Greg Ungerer <gerg@xxxxxxxxxxx>
>> > > Cc: Mike Frysinger <vapier.adi@xxxxxxxxx>
>> >
>> > The updated version looks ok to me anyways, and it's certainly an
>> > improvement over defining the same alignment requirements all over the
>> > place.
>> >
>> > Acked-by: Paul Mundt <lethal@xxxxxxxxxxxx>
>>
>> Quite a few people expressed quite a few reservations over v2.
>>
>> Are we all OK with a v3 merge?
>
> Paul and Mike had complaints. ÂPaul acked the last revision. ÂMike?
> We need this for upstream to compile on our configuration.

i thought my comments had all been addressed, so i dont have any problems
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/