Re: [PATCH 17/17] xen: disable MSI
From: Linus Torvalds
Date: Wed May 27 2009 - 17:48:16 EST
On Wed, 27 May 2009, Ingo Molnar wrote:
> hm, i have to concur. Too often it ends up splitting attention away
> from the title of the commit. I do reject (or fix up) bad impact
> lines - will stop doing them altogether if you think there's a net
> downside to them ...
I actually think that if there is a good reason for them, they can stay.
Just don't make it one of those "every commit that goes through me has to
Pu another way: if they actually add value in highlighting the commits
that _should_ stand out, then hey, by all means, keep such ones. I would
not at all object if it was an issue of
[ Impact: fix bugzilla entry 455123 ]
[ Impact: fix user-triggerable oops ]
or something that actually matters, and that you _want_ to stand out, and
that you may well _want_ to grep for.
It's when the whole series has them, and they don't add anything that
isn't better said in the summary line, _that's_ what I dislike.
So to take the above bugzilla example: it really wouldn't be a good
summary line (because the summary line should describe what the commit
does, not point to some bugzilla entry), but at the same time it's clearly
something that I do think we might want to automate the logs for.
IOW, that is something even I personally wouldn't mind adding to a commit,
to help people like Rafael that track bugzilla. It makes sense as a
special marker, even though it clearly _shoudln't_ be the summary. See?
Similarly, the "user-triggerable oops" might well be worth high-lighting
in some manner. Now, the summary _might_ talk about it, but equally well
the summary might be more specific in the actual implementation issue, and
then perhaps the impact line is worth it.
But if all commits have them (at least for the x86-tip), then it's not a
really highlight event any more, is it? At that point, anything it says is
probably just as well described by the summary line - at least for any
"regular" commits that aren't in some way worth the extra attention.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/