Re: [PATCH 17/17] xen: disable MSI

From: Ingo Molnar
Date: Wed May 27 2009 - 18:26:53 EST

* David Miller <davem@xxxxxxxxxxxxx> wrote:

> From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Date: Wed, 27 May 2009 08:34:22 -0700 (PDT)
> > I hate them. They are stupid. 90% of all the impact lines I see
> > are either (a) misleading or (b) totally inane and pointless.
> I just delete any Impact lines I see in patches sent to me, and I
> honestly suggest you do so as well.

Still you committed a fair number of them already:

earth4:~/tip> git log net/ | grep Impact:
Impact: Attribute functions with __acquires(...) resp. __releases(...).
Impact: Attribute function with __releases(...)
Impact: Remove redundant variable declarations, resp. rename
Impact: Attribute functions with __acquires(...) resp. __releases(...).
Impact: Include header file.
Impact: Use 'static const char[]' instead of 'static char[]', and
Impact: Trust in the comment and add '__force' to the cast.
Impact: Attribute function with __acquires(...) resp. __releases(...).

btw., these are one of the weirdest impact lines i've ever seen.

You seem to dismiss them unconditionally and indiscriminately,
without giving any thought to why good impact lines might be useful.

Good impact lines _are_ really useful to me in my everyday
maintenance workflow - while bad impact lines indeed are not.
So i try to commit and pull good ones only.

I challenge you to count the number of bad impact lines in the
current pending x86-next tree, compared to the number of good impact
lines there.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at