Re: [PATCH] Time out for possible dead loops during queuedinvalidation wait
From: Andrew Morton
Date: Wed May 27 2009 - 18:49:23 EST
On Wed, 27 May 2009 15:40:35 -0700
"Yu, Fenghua" <fenghua.yu@xxxxxxxxx> wrote:
> >> + WARN(1, "No space in invalidation queue.\n");
> >> + return -ENOSPC;
> >ENOSPC means "your disk filled up". I think it makes no sense to use
> >that error code in this context, even though it kinda sounds the same.
> Which error code is better? Is EAGAIN ok?
That depends on driver details - probably EIO would be suitable, dunno.
But all the callers of qi_submit_sync() seem to just drop the error
code on the floor:
/* should never fail */
and may well cause a kernel crash as a result.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/