Re: [PATCH] ftrace: Don't convert function's local variable namein macro
From: Frederic Weisbecker
Date: Wed May 27 2009 - 19:16:41 EST
On Thu, May 28, 2009 at 01:14:35AM +0200, Ingo Molnar wrote:
> * Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
> > On Wed, May 27, 2009 at 09:36:02PM +0800, Zhaolei wrote:
> > > "call" is a argument of macro, but it is also used as a local variable name of
> > > function in macro.
> > > We should keep this local variable name static although it haven't cause
> > > problem now.
> > >
> > > [ Impact: cleanup, no functionality changed ]
> > I'm applying it.
> > Note, I'm also changing the impact line. This is more than a
> > cleanup, it's a real fix to prevent from possible CPP side effects.
> > So I'll put instead:
> > [ Impact: prevent from accidental CPP substitution ]
> I suspect it should be something like:
> [ Impact: robustify macro ]
Ok, I take this one!
> or so.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/