Re: [PATCH] MMC: Add 400ms to CAFE SD controller resume path

From: Pierre Ossman
Date: Thu May 28 2009 - 04:48:42 EST

On Thu, 28 May 2009 01:36:29 -0700
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Fri, 22 May 2009 13:51:50 +0200 Pierre Ossman <pierre@xxxxxxxxx> wrote:
> >
> > Reading through that report, I don't believe you properly worked around
> > the bug. You only avoid bug 1339, but that's only mildly related.
> >
> > What this workaround does is to make sure that MMC_UNSAFE_RESUME
> > actually works. But if you change cards during suspend, the VFS bug
> > should reappear and you'll corrupt the partition table.
> What do you think the VFS did wrong here?

Might be the block layer as well. Somehow requests associated with an
old block device end up on the queue of a new block device. I don't
see how this can happen given Linux' device model, but somehow it does.

-- Pierre Ossman

WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end

Attachment: signature.asc
Description: PGP signature