Re: [PATCH] sched: Support current clocksource handling in fallbacksched_clock().

From: Thomas Gleixner
Date: Thu May 28 2009 - 08:23:25 EST


On Thu, 28 May 2009, Paul Mundt wrote:
> @@ -437,10 +441,19 @@ void clocksource_unregister(struct clocksource *cs)
> unsigned long flags;
>
> spin_lock_irqsave(&clocksource_lock, flags);
> +
> + if (sched_clocksource == cs) {
> + printk(KERN_WARNING "Refusing to unregister "
> + "scheduler clocksource %s", cs->name);

Hmm, isn't that dangerous ? The clocksource might be in a module or
in kmalloced memory which is going to be freed.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/