Re: [PATCH] Introduce a boolean "single_bit_set" function.
From: Robert P. J. Day
Date: Thu May 28 2009 - 08:33:46 EST
On Thu, 28 May 2009, Petr Tesarik wrote:
> Robert P. J. Day pÃÅe v Ät 23. 04. 2009 v 13:43 -0400:
> > A boolean single_bit_set() routine would simplify the numerous
> > constructs of the form (((n & (n - 1)) == 0)) when testing for
> > single-bitness.
> > Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
> > ---
> > This is similar to the current is_power_of_2() routine defined in
> > include/linux/log2.h, which is mathematically identical but,
> > semantically, should be defined independently just so the code is more
> > readable.
> > I'm open to an alternative function name.
> ispow2() ?
> Because what it really does is to check that a value is a power of two,
by the way, a search for places in the code that are candidates for
this kind of rewriting can be seen at one of my wiki kernel cleanup
scroll down, you'll see a section entitled "Testing for power of 2 or
a single bit set". lots of potential for clarification if people
think it's worth it.
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca
Linked In: http://www.linkedin.com/in/rpjday