Re: [PATCH 1/2] Dynamic Tick: Prevent clocksource wrapping duringidle

From: Thomas Gleixner
Date: Thu May 28 2009 - 16:36:42 EST


On Thu, 28 May 2009, Jon Hunter wrote:
> /**
> + * clocksource_max_deferment - Returns max time the clocksource can be
> deferred
> + * @cs: Pointer to clocksource
> + *
> + */
> +static inline s64 clocksource_max_deferment(struct clocksource *cs)

Please make this a real function. There is no reason to stick this
into a header file. The only user is clocksource.c anyway, so please
put it there as a static function and let the compiler decide what
to do with it.

Otherwise, I'm happy with it.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/