Re: [PATCH RFC] perf_counter: Don't swap contexts containinglocked mutex

From: Peter Zijlstra
Date: Fri May 29 2009 - 07:17:38 EST


On Fri, 2009-05-29 at 21:13 +1000, Paul Mackerras wrote:
> Ingo Molnar writes:
>
> > looping in the remove-context retry loop.
>
> Ah! We need to reload task inside the loop. And possibly in other
> places.

Thing is, after your patch this is called after the unclone, so the
context should be stable, still we see this. But yeah that loop needs
some care.

I also noticed we have races on cpuctx->task_ctx, I was looking at
removing it alltogether in favour of current->perf_counter_ctxp.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/