Re: [PATCH 3/4] [MTD] compat_ioctl cleanup

From: David Woodhouse
Date: Fri May 29 2009 - 10:58:21 EST


On Wed, 2009-04-08 at 22:53 -0700, Kevin Cernekee wrote:
>
> +static long mtd_compat_ioctl(struct file *file, unsigned int cmd,
> + unsigned long arg)
> +{
> + struct mtd_file_info *mfi = file->private_data;
> + struct mtd_info *mtd = mfi->mtd;
> + void __user *argp = (void __user *)arg;

Shouldn't that be 'argp = compat_ptr(arg)' ?

--
David Woodhouse Open Source Technology Centre
David.Woodhouse@xxxxxxxxx Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/