Re: [PATCH 0/11] Per-bdi writeback flusher threads v9

From: Artem Bityutskiy
Date: Fri May 29 2009 - 11:42:20 EST

Peter Zijlstra wrote:
On Thu, 2009-05-28 at 17:19 +0300, Artem Bityutskiy wrote:
Artem Bityutskiy wrote:
question is - should it? 'bdi_register()' a block device,
but we do not have one.
Sorry, wanted to say: 'bdi_register()' registers a block

BDI stands for backing device info and is not related to block devices
other than that block devices can also be (ok, always are) backing

If you want to do writeback, you need a backing device to write to. The
BDI is the device abstraction for writeback.

I see, thanks. The below UBIFS patch fixes the issue. I'll
push it to ubifs-2.6.git tree, unless there are objections.

From: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx>
Subject: [PATCH] UBIFS: do not forget to register BDI device

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx>
fs/ubifs/super.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 2349e2c..d1ac967 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -1929,6 +1929,9 @@ static int ubifs_fill_super(struct super_block *sb, void *data, int silent)
err = bdi_init(&c->bdi);
if (err)
goto out_close;
+ err = bdi_register(&c->bdi, NULL, "ubifs");
+ if (err)
+ goto out_close;

err = ubifs_parse_options(c, data, 0);
if (err)

Best Regards,
Artem Bityutskiy (ÐÑÑÑÐ ÐÐÑÑÑÐÐÐ)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at