Re: [PATCH 22/24] sysfs: Make sysfs_rename_link atomic

From: Eric W. Biederman
Date: Fri May 29 2009 - 13:18:17 EST

Tejun Heo <tj@xxxxxxxxxx> writes:

> Eric W. Biederman wrote:
>> From: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
>> Use the existing sysfs_rename to make sysfs_rename_link an atomic
>> operation that does less work. While I am at add additional sanity
>> checking to ensure it is a symlink I am renaming.
>> Acked-by: Kay Sievers <kay.sievers@xxxxxxxx>
>> Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxxxxxxxx>
> It would be really nice to merge or group this together with the first
> three patches. Other than that,

Perfection is the enemy of the good on that one. That just convolutes
things unnecessarily, makes the patches harder to review, and requires
additional testing.

I much prefer to work in a tree without rewinding.

> Acked-by: Tejun Heo <tj@xxxxxxxxxx>
> --
> tejun
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at