Re: [PATCH 2/2] cciss: Fix SCSI device reset handler

[Andrew Morton]

On Wed, 27 May 2009 15:30:07 -0500
scameron@xxxxxxxxxxxxxxxxxxxxxxx wrote:

> +static int wait_for_device_to_become_ready(ctlr_info_t *h,
> +	unsigned char lunaddr[])
> +{
> +	int rc;
> +	int count = 0;
> +	int waittime = HZ;
> +	CommandList_struct *c;
> +
> +	c = cmd_alloc(h, 1);
> +	if (!c) {
> +		printk(KERN_WARNING "cciss%d: out of memory in "
> +			"wait_for_device_to_become_ready.\n", h->ctlr);
> +		return IO_ERROR;
> +	}
> +
> +	/* Send test unit ready until device ready, or give up. */
> +	while (count < 20) {
> +
> +		/* Wait for a bit.  do this first, because if we send
> +		 * the TUR right away, the reset will just abort it.
> +		 */
> +		set_current_state(TASK_INTERRUPTIBLE);
> +		schedule_timeout(waittime);

That's schedule_timeout_interruptible().

The problem with interruptible sleeps of this nature is that they are
no-ops if the calling process happens to have signal_pending().  I
suspect that this condition will break your driver.

If so, switching to schedule_timeout_uninterruptible() will unbreak it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/