Re: [PATCH 14/38] Remove struct mm_struct::exe_file et al
From: Alexey Dobriyan
Date: Sun May 31 2009 - 17:54:36 EST
On Tue, May 26, 2009 at 04:24:15PM -0700, Andrew Morton wrote:
> On Tue, 26 May 2009 04:36:18 -0700
> Matt Helsley <matthltc@xxxxxxxxxx> wrote:
> > I don't see any mention in the changelog of the point brought up by Ingo:
> > http://lkml.org/lkml/2009/4/10/105
> Nor of Eric's comments.
> Alexey, pleeeze don't do this. We (read: I) heavily depend upon patch
> submitters to keep track of outstanding issues and review comments,
> If the patch submitter simply blows these things off then it devolves
> to me having to keep track of each patch's issue list as well as the
> patch itself. My workload goes up by a factor of N and the error rate
> goes up by N^2 :(
"Security" and "holding ->mmap_sem" were answered and dismissed.
You can't do readlink(2) on /proc/*/exe if you can't ptrace task.
So no new possible holes are created.
->mmap_sem was held since /proc/*/exe was added and nobody cared.
And, again, you can't readlink _any_ /proc/*/exe.
Patch simply restores code to year-back state.
I'll send removal and readddition of "struct path" as separate things
And BTW, there is something unnatural when executable path is attached
to mm_struct(!) not task_struct, so yet another argument to ->exe_file
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/