Re: [PATCH -v3] flat: fix data sections alignment

[Michal Simek]

Andrew Morton wrote:
> On Thu, 28 May 2009 09:08:02 +0900
> Paul Mundt <lethal@xxxxxxxxxxxx> wrote:
>
>   
>> On Wed, May 27, 2009 at 01:43:57PM -0700, Andrew Morton wrote:
>>     
>>> On Wed, 27 May 2009 13:49:56 +0200
>>> Johannes Weiner <jw@xxxxxxxxx> wrote:
>>>       
>>>> On Tue, May 05, 2009 at 04:08:47PM +0200, Johannes Weiner wrote:
>>>>         
>>>>> On Thu, Apr 09, 2009 at 04:25:53PM +0200, Johannes Weiner wrote:
>>>>>           
>>>>>> On Thu, Apr 02, 2009 at 01:53:43PM -0700, Andrew Morton wrote:
>>>>>> Paul and Mike had complaints.  Paul acked the last revision.  Mike?
>>>>>> We need this for upstream to compile on our configuration.
>>>>>>             
>>> Who is Mike?
>>>
>>> (A pox upon email clients which strip real names)
>>>
>>>       
>>>>> Can we get this merged?  Nobody complained.
>>>>>           
>>>> <periodic echo-request>
>>>>
>>>> What are the plans on this now?  I assume it drowned in other changes...
>>>> Is it too late to get this in .30 now?
>>>>         
>>> The patch had a fairly shaky start and it's been unclear to me that
>>> everyone is happy with it and has tested it.
>>>
>>>  arch/arm/include/asm/flat.h      |    3 --
>>>  arch/blackfin/include/asm/flat.h |    1 
>>>  arch/h8300/include/asm/flat.h    |    1 
>>>  arch/m32r/include/asm/flat.h     |    1 
>>>  arch/m68k/include/asm/flat.h     |    1 
>>>  arch/sh/include/asm/flat.h       |    1 
>>>  fs/binfmt_flat.c                 |   46 ++++++++++++++++++++++++++-------------
>>>
>>> I guess ARM is the major architecture amongst that lot.  Have Russell
>>> and co had a decent look through this?
>>>
>>>       
>> The problem here is that the ARM nommu people seem to have disappeared
>> shortly after getting their changes merged. I see no activity within the
>> kernel for ARM nommu since 2006.
>>     
>
> heh, OK.  Oskar touched it last, so he's now ARM nommu maintainer.
>
>   
>> Given that xtensa has a need for this in
>> its nommu port and people are working on it presently, there certainly
>> has to be a limit to how far we go in allowing an outdated and
>> effectively abandoned port from blocking progress. Perhaps Russell has a
>> more optimistic outlook on the future of ARM nommu, though.
>>
>> The only architectures in that list presently active in the linux nommu
>> space in terms of development, support, and shipping products, are
>> blackfin, m68k, and sh. This too has been the case for years. Microblaze
>> has recently been added (which will also need the same change to its
>> flat.h), and it seems the xtensa folks are at least presently willing to
>> do more than the bare minimum to keep their port limping along.
>>     
>
> OK, thanks, I'll send it in to Linus this week.
>   
Can you remove flat_stack_align for Microblaze too? It should be in this
patch too.

Thanks,
Michal

diff --git a/arch/microblaze/include/asm/flat.h
b/arch/microblaze/include/asm/flat.h
index acf0da5..6847c15 100644
--- a/arch/microblaze/include/asm/flat.h
+++ b/arch/microblaze/include/asm/flat.h
@@ -13,7 +13,6 @@
 
 #include <asm/unaligned.h>
 
-#define        flat_stack_align(sp) /* nothing needed */
 #define        flat_argvp_envp_on_stack()      0
 #define        flat_old_ram_flag(flags)        (flags)
 #define        flat_reloc_valid(reloc, size)   ((reloc) <= (size))




> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>   


-- 
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/