Re: [PATCH v3] gpio: driver for PrimeCell PL061 GPIO controller

[Baruch Siach]

Hi Andrew,

On Tue, Jun 02, 2009 at 04:09:02PM -0700, Andrew Morton wrote:
> On Tue,  2 Jun 2009 23:48:10 +0300
> Baruch Siach <baruch@xxxxxxxxxx> wrote:
> 
> > This is a driver for the ARM PrimeCell PL061 GPIO AMBA peripheral. The driver
> > is implemented using the gpiolib framework.
> 
> x86_64 allmodconfig:
> 
> drivers/gpio/pl061.c: In function 'pl061_probe':
> drivers/gpio/pl061.c:254: error: 'SZ_4K' undeclared (first use in this function)
> drivers/gpio/pl061.c:254: error: (Each undeclared identifier is reported only once
> drivers/gpio/pl061.c:254: error: for each function it appears in.)
> drivers/gpio/pl061.c:306: error: implicit declaration of function 'set_irq_flags'
> drivers/gpio/pl061.c:306: error: 'IRQF_VALID' undeclared (first use in this function)
> 
> I'll put a depends-on-ARM in there...

I guess a depends-on-ARM_AMBA would be better.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@xxxxxxxxxx - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/