Re: [PATCH v2] usb: avoid PM error messages during resume if a device was disconnected

From: Rafael J. Wysocki
Date: Wed Jun 03 2009 - 04:09:15 EST


On Wednesday 03 June 2009, Alan Stern wrote:
> On Wed, 3 Jun 2009, Rafael J. Wysocki wrote:
>
> > > + /* Avoid PM error messages for devices disconnected while suspended
> > > + * as we'll display regular disconnect messages just a bit later.
> > > + */
> > > + if (status == -ENODEV)
> > > + return 0;
> > > + return status;
> >
> > + return status == -ENODEV ? 0 : status;
> >
> > maybe?
> >
> > > }
> > >
> > > #endif /* CONFIG_PM */
>
> Personally, I would do:
>
> if (status == -ENODEV)
> status = 0;
> return status;
>
> It doesn't make any difference; they are all equally good.
>
> Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

OK

Am I supposed to take this patch directly or push it to Greg?

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/