Re: linux-next: Tree for June 3 (staging)

[Yunpeng Gao]

On Thu, Jun 04, 2009 at 07:11:52AM +0800, Greg KH wrote:
> On Wed, Jun 03, 2009 at 08:40:33AM -0700, Randy Dunlap wrote:
> > Greg KH wrote:
> > > On Wed, Jun 03, 2009 at 08:24:49AM -0700, Randy Dunlap wrote:
> > >> Stephen Rothwell wrote:
> > >>> Hi all,
> > >>>
> > >>> Looks like a real rush since -rc7 ...
> > >>
> > >> drivers/staging/comedi/drivers/adq12b.c:328: error: implicit declaration of function 'udelay'
> > >>
> > >>
> > >> drivers/staging/mrst_nand/ffsport.c:360:error: 'struct request' has no member named 'sector'
> > >> drivers/staging/mrst_nand/ffsport.c:376:error: 'struct request' has no member named 'sector'
> > >> drivers/staging/mrst_nand/ffsport.c:376:error: 'struct request' has no member named 'current_nr_sectors'
> > >> drivers/staging/mrst_nand/ffsport.c:380:error: 'struct request' has no member named 'sector'
> > >> drivers/staging/mrst_nand/ffsport.c:381:error: 'struct request' has no member named 'current_nr_sectors'
> > >> drivers/staging/mrst_nand/ffsport.c:392:error: 'struct request' has no member named 'current_nr_sectors'
> > >> drivers/staging/mrst_nand/ffsport.c:499:error: implicit declaration of function 'elv_next_request'
> > >> drivers/staging/mrst_nand/ffsport.c:517:error: implicit declaration of function 'end_request'
> > >> drivers/staging/mrst_nand/ffsport.c:738:error: implicit declaration of function 'blk_queue_hardsect_size'
> > > 
> > > Can I get your .config for this?  It works here with a "default" one.
> > 
> > attached (for mrst_nand/ffsport.c build errors)
> 
> Ah, thanks, figured it out.
> 
> Gao, this looks like a problem in your ffsport.c code.  It isn't up to
> date with the 2.6.30-rc8 kernel tree.  Care to send me a follow-on patch
> to fix this up?
> 
> thanks,
> 
> greg k-h

Hi Greg,
   I have fixed these compiling bugs in file ffsport.c.

   But just found that my email client (Outlook) will replace
   TAB with blanks automatically. So, unfortunately, all the
   TABs in my first submission patch have been changed to
   blanks by the Outlook.
   
   So I'd like to use the Mutt email client and re-submit
   the patch as below (the bug-fix of ffsport.c has been included).
   Does it make sense?

   Thanks.

   Rgds,
   Yunpeng

-------------------------------------------------------------------------