Re: [PATCH] cpumask: alloc blank cpumask left over

From: Rusty Russell
Date: Fri Jun 05 2009 - 00:58:22 EST


On Fri, 5 Jun 2009 06:31:31 am Yinghai Lu wrote:
> avoid suprise when MAXSMP is enabled
>
> Signed-off-by: Yinghai Lu <yinghai.lu@xxxxxxxxxx>

I understand the temptation, but two questions arise:
1) Shouldn't we actually audit to see if any of these are currently problems,
and
2) Should the non-MAXSMP alloc_cpumask_var_node (currently a noop) zero the
mask if __GFP_ZERO is set?

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/