Re: [this_cpu_xx 07/11] xfs_icsb_modify_counters does not need "cpu" variable

[Christoph Hellwig]

On Fri, Jun 05, 2009 at 03:18:26PM -0400, cl@xxxxxxxxxxxxxxxxxxxx wrote:
> The xfs_icsb_modify_counters() function no longer needs the cpu variable
> if we use this_cpu_ptr() and we can get rid of get/put_cpu().

Looks good to me.  While you're at it you might also remove the
superflous cast of the this_cpu_ptr return value.


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Btw, any reason this_cpu_ptr doesn't do the preempt_disable itself
and has something paired to reverse it?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/