Re: add bcm47xx watchdog driver

From: matthieu castet
Date: Fri Jun 05 2009 - 16:04:15 EST


Andrew Morton wrote:
On Thu, 04 Jun 2009 22:24:56 +0200
matthieu castet <castet.matthieu@xxxxxxx> wrote:

This add watchdog driver for broadcom 47xx device.
It uses the ssb subsytem to access embeded watchdog device.

...

--- linux-2.6.orig/drivers/watchdog/Kconfig 2009-05-25 22:22:02.000000000 +0200
+++ linux-2.6/drivers/watchdog/Kconfig 2009-05-25 22:26:06.000000000 +0200
@@ -764,6 +764,12 @@
help
Hardware driver for the built-in watchdog timer on TXx9 MIPS SoCs.
+config BCM47XX_WDT
+ tristate "Broadcom BCM47xx Watchdog Timer"
+ depends on BCM47XX
+ help
+ Hardware driver for the Broadcom BCM47xx Watchog Timer.

Shouldn't there be some SSB dependencies in Kconfig here?
No, because :
config BCM47XX
bool "BCM47XX based boards"
[...]
select SSB
select SSB_DRIVER_MIPS
select SSB_DRIVER_EXTIF
select SSB_EMBEDDED
select SSB_PCICORE_HOSTMODE if PCI
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/