Re: [PATCH -tip] x86: cpu/proc.c adding extended_cpuid_level for/proc/cpuinfo

[H. Peter Anvin]

Jaswinder Singh Rajput wrote:
> Hello Andrew,
> 
> On Tue, 2009-05-12 at 23:21 -0700, Andrew Morton wrote:
>> On Tue, 12 May 2009 12:44:42 +0530 Jaswinder Singh Rajput <jaswinder@xxxxxxxxxx> wrote:
>>
>>> +		   "ext cpuid level\t: 0x%x\n"
>> It's unobvious what "ext" means.  External?
>>
>> Can we make it "extended cpuid level"?
> 
> extended cpuid level will look like this :
> 
> fpu		: yes
> fpu_exception	: yes
> cpuid level	: 5
> wp		: yes
> extended cpuid level: 0x80000008
> flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe constant_tsc pebs bts pni dtes64 monitor ds_cpl cid
> 

The more I'm thinking about this I think it was a mistake to put cpuid
level: there in the first place, too.  My opinion is increasingly to
leave this to x86info or other user-space tools.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/