Re: [PATCH] kmemcheck: make bitfield annotations be valid C

From: Al Viro
Date: Sat Jun 06 2009 - 02:25:33 EST


On Sat, May 16, 2009 at 09:40:08AM +0300, Pekka Enberg wrote:
> On Fri, May 15, 2009 at 10:55 PM, Vegard Nossum <vegard.nossum@xxxxxxxxx> wrote:
> > From bb8926742d87da95aeb373bc2d4b35a554c5001b Mon Sep 17 00:00:00 2001
> > From: Vegard Nossum <vegard.nossum@xxxxxxxxx>
> > Date: Fri, 15 May 2009 21:34:36 +0200
> > Subject: [PATCH] kmemcheck: make bitfield annotations be valid C
> >
> > According to Al Viro, the syntax we were using (putting #ifdef inside
> > macro arguments) was not valid C. He also suggested using begin/end
> > markers instead, which is what we do now.
> >
> > Reported-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Vegard Nossum <vegard.nossum@xxxxxxxxx>
>
> Acked-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
>
> Al, are you okay with this?

Looks sane
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/