Re: [this_cpu_xx 04/11] Use this_cpu ops for network statistics

From: Ingo Molnar
Date: Mon Jun 08 2009 - 16:54:43 EST



* Christoph Lameter <cl@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Mon, 8 Jun 2009, Robin Holt wrote:
>
> > > + this_cpu_inc((net)->ct.stat->count)
> >
> > Why not put this on one line?
> > #define NF_CT_STAT_INC_ATOMIC(net, count) this_cpu_inc((net)->ct.stat->count)
>
> Would be more than 78 characters in a line.

I think you can ignore such types of warnings in general. I think
checkpatch should be silent up to 90 chars or so, if there's not
more than say 3 tabs in that line. (if there's a lot of tabs that
means the indentation level is wrong.)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/