Re: [PATCH 0/4] RFC - ksm api change into madvise

From: Izik Eidus
Date: Tue Jun 09 2009 - 00:50:28 EST


On Mon, 08 Jun 2009 23:10:30 +0300
Izik Eidus <ieidus@xxxxxxxxxx> wrote:

> Hugh Dickins wrote:
> > On Mon, 8 Jun 2009, Izik Eidus wrote:

> >
> > If you needed to writeprotect pages with mapcount 2, 3, ... then
> > indeed you'd want to do it in rmap.c, and you wouldn't want to
> > specialcase mapcount 1. But I'm saying you don't need to do the
> > writeprotection with mapcount 2, 3, ...; therefore better just
> > to do it (again, no need to special case mapcount 1) in ksm.c.
> >
> > Cutting out a body of code: that's as clean as clean can be.
> >
> >
> >
> Make sense, i will send patch today that merge that code into ksm.c
> (without all the rmap walking)
>
>

How does this look like?