Re: [PATCH] Re:[BUILD FAILURE 04/04] Next June 04:PPC64 randconfig[drivers/net/ucc_geth.o]
From: Michael Ellerman
Date: Wed Jun 10 2009 - 22:03:26 EST
On Thu, 2009-06-11 at 07:26 +0530, Subrata Modak wrote:
> On Thu, 2009-06-11 at 11:05 +1000, Stephen Rothwell wrote:
> > Hi Subrata,
> > On Wed, 10 Jun 2009 23:13:23 +0530 Subrata Modak <subrata@xxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > /* Find the TBI PHY. If it's not there, we don't support SGMII */
> > > - ph = of_get_property(np, "tbi-handle", NULL);
> > > + ph = (phandle *)of_get_property(np, "tbi-handle", NULL);
> > You don't need this cast because of_get_property() returns "void *".
> True. But without this gcc complains:
> CC [M] drivers/net/ucc_geth.o
> drivers/net/ucc_geth.c: In function âucc_geth_probeâ:
> drivers/net/ucc_geth.c:3824: warning: assignment discards qualifiers from pointer target type
And what does that warning actually mean?
Your cast actually introduces a bug.
Description: This is a digitally signed message part