Re: [PATCH] hwmon: Add driver for VIA CPU core temperature

From: Andrew Morton
Date: Thu Jun 11 2009 - 18:34:40 EST

On Wed, 10 Jun 2009 17:40:31 +0000 (UTC)
Tomaz Mertelj <tomaz.mertelj@xxxxxxxxxxxxxx> wrote:

> Harald Welte <HaraldWelte <at>> writes:
> >
> > This is a driver for the on-die digital temperature sensor of
> > VIA's recent CPU models.
> >
> > Signed-off-by: Harald Welte <HaraldWelte <at>>
> >
> Harald,

You carefully removed Harald from Cc: so he probably didn't read your

> I tested it on kernel on VIA VB7002 motherboard and it does not work
> correctly.
> Output form sensors:
> via-cputemp-isa-0000
> Adapter: ISA adapter
> Core 0: +0.0 C
> On the other hand
> cat '/sys/class/hwmon/hwmon2/device/driver/via-cputemp.0/temp1_input' outputs
> numbers between 25-27.

Thanks for testing it.

Harald, please cc myself on updates to this patch.

<looks quickly at the patch>

It has a few trivial coding-style glitches. Please use checkpatch.

Please take a look at using hotcpu_notifier() rather than a bare
register_hotcpu_notifier(). Many ifdefs should fall away as a result.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at