Re: [PATCH 3/6] cpumask: avoid playing with cpus_allowed inpowernow-k8.c
From: Dave Jones
Date: Thu Jun 11 2009 - 19:25:35 EST
On Thu, Jun 11, 2009 at 10:59:58PM +0930, Rusty Russell wrote:
> From: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> It's generally a very bad idea to mug some process's cpumask: it could
> legitimately and reasonably be changed by root, which could break us
> (if done before our code) or them (if we restore the wrong value).
> I did not replace powernowk8_target; it needs fixing, but it grabs a
> mutex (so no smp_call_function_single here) but Mark points out it can
> be called multiple times per second, so work_on_cpu is too heavy.
This one clashes with some diffs I merged earlier in cpufreq.git.
Can you rebase on top of that please?
(The other two were fine).
Otherwise, they all look ok to me. As long as they survive testing I
see no reason not to push them for .31.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/