Re: [PATCH 1/2] posix-cpu-timers: avoid do_sys_times() races with__exit_signal()

From: Oleg Nesterov
Date: Fri Jun 12 2009 - 09:52:53 EST


On 06/12, Stanislaw Gruszka wrote:
>
> Protect thread_group_cputime() call by siglock, to avoid possible (but
> to be honest - very improbable) double times accounting of exiting task.
> This is revert of commit 2b5fe6de58276d0b5a7c884d5dbfc300ca47db78
> "thread_group_cputime: move a couple of callsites outside of ->siglock",
> but implementation of thread_group_cputime() was different then.

Yes, at that time thread_group_cputime() was reading per-cpu data, and
->siglock was unneeded.

I think the patch is correct.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/