Re: [PATCH 1/5] HWPOISON: define VM_FAULT_HWPOISON to 0 when featureis disabled

From: Linus Torvalds
Date: Fri Jun 12 2009 - 11:29:50 EST




On Fri, 12 Jun 2009, Ingo Molnar wrote:
>
> This seems like trying to handle a failure mode that cannot be and
> shouldnt be 'handled' really. If there's an 'already corrupted' page
> then the box should go down hard and fast, and we should not risk
> _even more user data corruption_ by trying to 'continue' in the hope
> of having hit some 'harmless' user process that can be killed ...

No, the box should _not_ go down hard-and-fast. That's the last thing we
should *ever* do.

We need to log it. Often at a user level (ie we want to make sure it
actually hits syslog, possibly goes out the network, maybe pops up a
window, whatever).

Shutting down the machine is the last thing we ever want to do.

The whole "let's panic" mentality is a disease.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/