Re: [PATCH] scripts/checksyscalls.sh: only whine perf_counter_open when supported

From: Mike Frysinger
Date: Fri Jun 12 2009 - 11:30:04 EST


On Fri, Jun 12, 2009 at 11:21, Ingo Molnar wrote:
> * Mike Frysinger <vapier.adi@xxxxxxxxx> wrote:
>> the perf counter code explicitly requires:
>> ...
>> Â- support for atomic64 types (unless i missed something, x86 is the
>> only 32bit system that supports these)
>
> A wrapper suffices - should probably be librarized into lib/.

wonder if we can trick Arnd into doing that ...

>> Â- some perf stubs (like set_perf_counter_pending() -- prototype
>> really should be in common perf_counters headers rather than forcing
>> the arch to copy & paste the exact same line)
>
> Agreed.

can i assume you'll take care of that ?

>> not that any of this is documented ...
>
> Patches are welcome :-)

i cant find anything in Documentation/ covering perf counters. did i
miss some file ?

also, i was going just by a quick compile test. dont know what else
is actually required since there's no chance of me trying to get this
to work on Blackfin anytime soon ...

> You are right that the requirements are not necessarily trivial for
> every arch - so i guess our original patch is correct.

there is also some ptrace type piece missing for the Blackfin arch,
but that looks like something that i should just implement as everyone
else is doing it.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/